watch: add file watching with automatic process restart#4
Merged
Conversation
Add watching to procman where it benefits projects of all languages
rather than build it into Ruby or Go projects/frameworks.
Syntax: add `# watch: PATTERNS` to Procfile.dev entries:
web: bundle exec ruby cmd/web.rb # watch: lib/**/*.rb
On file change matching a pattern, procman sends SIGINT to the process,
waits for exit, and restarts. Changes are debounced (500ms) to avoid
rapid restarts during multi-file saves.
Processes without a watch annotation behave exactly as before.
Co-Authored-By: Warp <agent@warp.dev>
- Fix data race in running(): use mutex-protected started/stopped flags instead of reading exec.Cmd internals (ProcessState) without sync - Fix hanging goroutines on shutdown: use time.AfterFunc instead of goroutine waiting on timer channel that could block forever if drained - Consolidate to single shared fsnotify watcher at manager level - Improve test cleanup to avoid orphaned processes Co-Authored-By: Warp <agent@warp.dev>
croaky
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add watching to procman where it benefits projects of all languages
rather than build it into Ruby or Go projects/frameworks.
Syntax: add
# watch: PATTERNSto Procfile.dev entries:On file change matching a pattern, procman sends SIGINT to the process,
waits for exit, and restarts. Changes are debounced (500ms) to avoid
rapid restarts during multi-file saves.
Processes without a watch annotation behave exactly as before.
Co-Authored-By: Warp agent@warp.dev